Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2665183002: Ensure .mm column limit stays at 80 for newer clang-format binaries (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure .mm column limit stays at 80 for newer clang-format binaries BUG=686650 R=thakis@chromium.org

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M .clang-format View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (4 generated)
Dan Beam
3 years, 10 months ago (2017-01-31 18:35:17 UTC) #5
Nico
lgtm, sigh :-( https://codereview.chromium.org/2665183002/diff/1/.clang-format File .clang-format (right): https://codereview.chromium.org/2665183002/diff/1/.clang-format#newcode38 .clang-format:38: ColumnLimit: 80 please add a todo ...
3 years, 10 months ago (2017-01-31 18:36:18 UTC) #6
Nico
3 years, 10 months ago (2017-01-31 18:37:21 UTC) #7 
actually, a bunch of other projects also get our clang-format (say skia) and
they won't have this

Powered by Google App Engine
This is Rietveld 408576698