Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: content/browser/renderer_host/media/audio_input_renderer_host.cc

Issue 2665163002: Refactor AudioInputController and split stat by stream type. (Closed)
Patch Set: Also split CallbackError Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_input_renderer_host.cc
diff --git a/content/browser/renderer_host/media/audio_input_renderer_host.cc b/content/browser/renderer_host/media/audio_input_renderer_host.cc
index 9bb4969ee600f91a51df54c512a49d08944b63bb..ee1379b1d52f09cdec21eccd839f54cd55a5117a 100644
--- a/content/browser/renderer_host/media/audio_input_renderer_host.cc
+++ b/content/browser/renderer_host/media/audio_input_renderer_host.cc
@@ -368,14 +368,9 @@ void AudioInputRendererHost::DoCreateStream(
if (entry->controller.get() && type == MEDIA_DESKTOP_AUDIO_CAPTURE)
IncrementDesktopCaptureCounter(TAB_AUDIO_CAPTURER_CREATED);
} else {
- // We call CreateLowLatency regardless of the value of
- // |audio_params.format|. Low latency can currently mean different things in
- // different parts of the stack.
- // TODO(grunell): Clean up the low latency terminology so that it's less
tommi (sloooow) - chröme 2017/02/01 21:07:25 good to clean this up. I wasn't aware of this TODO
- // confusing.
- entry->controller = media::AudioInputController::CreateLowLatency(
- audio_manager_, this, audio_params, device_id, entry->writer.get(),
- std::move(debug_writer), user_input_monitor_,
+ entry->controller = media::AudioInputController::Create(
+ audio_manager_, this, entry->writer.get(), user_input_monitor_,
+ std::move(debug_writer), audio_params, device_id,
config.automatic_gain_control);
oss << ", AGC=" << config.automatic_gain_control;

Powered by Google App Engine
This is Rietveld 408576698