Issue 2665143004: Fix various alignments to make ARM precompilation work on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2665143004: Fix various alignments to make ARM precompilation work on Windows. (Closed)

Created:
3 years, 10 months ago by Florian Schneider

Modified:
3 years, 10 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix various alignments to make ARM precompilation work on Windows. The alignments have to match for the simulators across different OSes to generate correct precompiled code. Fixes #28575. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/e27226f557989b2b4a5c51398455408bb0fe8bbb

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	runtime/vm/os_win.cc	View	1 2	2 chunks	+12 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

3 years, 10 months ago (2017-02-01 01:06:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
e27226f557989b2b4a5c51398455408bb0fe8bbb (presubmit successful).