Issue 266513003: Reland enable VK overscroll by default. Fixed ash unittest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 266513003: Reland enable VK overscroll by default. Fixed ash unittest. (Closed)

Created:
6 years, 7 months ago by kevers

Modified:
6 years, 7 months ago

Reviewers:
oshima

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reland enable VK overscroll by default. Fixed ash unittest. BUG=242933 Original commit broke ash_unittests for restoration of work area after login. With overscrolling, the size of the work area is no longer changes as the keyboard is shown or hidden. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267267

Patch Set 1 #

Patch Set 2 : re-enable flag. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	M	ash/root_window_controller_unittest.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
	M	ui/keyboard/keyboard_util.cc	View	1	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/266513003/20001

6 years, 7 months ago (2014-04-30 14:51:12 UTC) #4

Message was sent while issue was closed.

Change committed as 267267

Expand Messages | Collapse Messages