sdk/lib/_internal/compiler/implementation/resolution/members.dart - Issue 26651006: Switch dart2js 'typedef name = mixinApplication' to 'class name = mixinApplication'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 26651006: Switch dart2js 'typedef name = mixinApplication' to 'class name = mixinApplication'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/dart_backend/utils.dart ('k') | sdk/lib/_internal/compiler/implementation/scanner/listener.dart » ('j') | sdk/lib/_internal/compiler/implementation/scanner/parser.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart

diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart

index f09879ab20914fcddc018b49ab112a750cde9c09..8af2acd0fccad83fc45f8dfb0f3f4d0ba7a32988 100644

--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart

+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart

@@ -3686,6 +3686,11 @@ class ClassResolverVisitor extends TypeDefinitionVisitor {

compiler.ensure(element != null);

compiler.ensure(element.resolutionState == STATE_STARTED);

+ if (identical(node.classKeyword.stringValue, 'typedef')) {

+ compiler.reportWarning(node.classKeyword,

ahe 2013/10/10 11:30:15 Add TODO that this should be a compile-time error

aam-me 2013/10/11 03:02:06 Done.

+ MessageKind.DEPRECATED_TYPEDEF_MIXIN_SYNTAX);

ahe 2013/10/10 11:30:15 Weird indentation.

aam-me 2013/10/11 03:02:06 Done.

+ }

InterfaceType type = element.computeType(compiler);

scope = new TypeDeclarationScope(scope, element);

resolveTypeVariableBounds(node.typeParameters);