Issue 2665053004: Implement completion in WithDirective.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2665053004: Implement completion in WithDirective. (Closed)

Created:
3 years, 10 months ago by scheglov

Modified:
3 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -5 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/dart/optype.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/completion_test.dart	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/optype_test.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Brian Wilkerson

I guess I don't need to create an issue for this then :-) lgtm

3 years, 10 months ago (2017-01-31 23:05:27 UTC) #2

scheglov

3 years, 10 months ago (2017-01-31 23:07:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
75fff1fdb6e3724e937933a4561446e3c0937115 (presubmit successful).