Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2665043003: Simplify the API for incremental_resolved_ast_generator. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Simplify the API for incremental_resolved_ast_generator. The use of a two-layer map will dovetail well with changes I have planned for the AnalysisDriver. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b489ae5a5f81d3b3879758599218d648a02dca3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -42 lines) Patch
M pkg/front_end/lib/incremental_resolved_ast_generator.dart View 3 chunks +12 lines, -18 lines 0 comments Download
M pkg/front_end/lib/src/incremental_kernel_generator_impl.dart View 3 chunks +5 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart View 3 chunks +4 lines, -6 lines 0 comments Download
M pkg/front_end/test/incremental_resolved_ast_generator_test.dart View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 10 months ago (2017-01-31 21:30:13 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-01-31 21:32:29 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as b489ae5a5f81d3b3879758599218d648a02dca3a (presubmit successful).
3 years, 10 months ago (2017-01-31 21:35:00 UTC) #5
danrubel
3 years, 10 months ago (2017-02-01 14:12:19 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698