Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2665013002: Issue 28550. Fix for resynthesizing invalid elements as declared types. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update link.dart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -16 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 6 chunks +15 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 9 chunks +32 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-01-30 23:06:52 UTC) #1
Paul Berry
lgtm
3 years, 10 months ago (2017-01-31 16:28:04 UTC) #2
scheglov
3 years, 10 months ago (2017-01-31 17:26:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b8aca22c6aba61898bd17b31a5cbba22482f3f43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698