Fix background compiler issue with new-space allocation in the parser.

Fix background compiler issue with new-space allocation in the parser.

Field::GetterName would allocate in new-space which is not allowed
during background compilation.

Fixes #26316.

R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/7ac05a4e0265a9a6a6a3d0724e4ec548a0f63ba1

[Florian Schneider, 2017-01-30 22:57:36]

fschneider@google.com changed reviewers:
+ asiva@google.com

[hausner, 2017-01-30 23:01:02]

hausner@google.com changed reviewers:
+ hausner@google.com

[hausner, 2017-01-30 23:01:03]

DBC

https://codereview.chromium.org/2665003002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2665003002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:11477: String::ZoneHandle(Z,
Field::GetterSymbol(func_name));
I don't think we want to create a symbol for the getter name unless we know for
sure that the getter exists. Otherwise, we end up creating unnecessary symbols.

[Florian Schneider, 2017-01-30 23:30:23]

https://codereview.chromium.org/2665003002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2665003002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:11477: String::ZoneHandle(Z,
Field::GetterSymbol(func_name));
On 2017/01/30 23:01:03, hausner wrote:
> I don't think we want to create a symbol for the getter name unless we know
for
> sure that the getter exists. Otherwise, we end up creating unnecessary
symbols.

Ok, instead I could for example create the temporary string in old-space only if
we're compiling on the background thread. That would be better anyway, since we
would not create old-space garbage for unoptimized compilations.

[hausner, 2017-01-30 23:31:50]

Using Field::LookupGetterSymbol() you can determine if a symbol for a particular
getter exists. If it does not exist, you can conclude that no getter exists,
hence you can prevent the creation of symbols that are unneeded (and will not be
GC'ed).

[Florian Schneider, 2017-01-31 01:19:36]

On 2017/01/30 23:31:50, hausner wrote:
> Using Field::LookupGetterSymbol() you can determine if a symbol for a
particular
> getter exists. If it does not exist, you can conclude that no getter exists,
> hence you can prevent the creation of symbols that are unneeded (and will not
be
> GC'ed).

Thanks Matthias. Ptal.

I replaced uses of GetterName/SetterName with LookupGetter-/SetterSymbol where
possible.

In some place where we call ThrowNoSuchMethodError we need a symbol in any case,
so there I left
GetterSymbol/SetterSymbol.

[hausner, 2017-01-31 01:41:29]

LGTM!

[Florian Schneider, 2017-02-01 01:21:09]

Description was changed from

==========
Fix background compiler issue with new-space allocation in the parser.

Field::GetterName would allocate in new-space which is not allowed
during background compilation.

Fixes #26316.
==========

to

==========
Fix background compiler issue with new-space allocation in the parser.

Field::GetterName would allocate in new-space which is not allowed
during background compilation.

Fixes #26316.

R=hausner@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7ac05a4e0265a9a6a6a3d0724e4ec548a0f63ba1
==========

[Florian Schneider, 2017-02-01 01:21:10]

Committed patchset #2 (id:20001) manually as
7ac05a4e0265a9a6a6a3d0724e4ec548a0f63ba1 (presubmit successful).