Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 26650005: gm: if test has no expectations, record its result as no-expectations regardless of ignoreFailure (Closed)

Created:
7 years, 2 months ago by epoger
Modified:
7 years, 2 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com, borenet
Visibility:
Public.

Description

gm: if test has no expectations, record its result as no-expectations regardless of ignoreFailure After https://code.google.com/p/skia/source/detail?r=11640 ('Ignore any pdf-poppler GM failures'), there are a bunch of pdf-poppler tests showing up as failure-ignored at http://c128.i.corp.google.com/production-gm-diffs/latest/view.html Make them go away. R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=11703

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -27 lines) Patch
M gm/gmmain.cpp View 2 chunks +26 lines, -24 lines 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt View 1 chunk +1 line, -1 line 1 comment Download
M gm/tests/run.sh View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
epoger
https://codereview.chromium.org/26650005/diff/1/gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt File gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt (right): https://codereview.chromium.org/26650005/diff/1/gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt#newcode18 gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt:18: "ignore-failure" : true I adjusted this self-test a bit: ...
7 years, 2 months ago (2013-10-09 19:09:22 UTC) #1
epoger
ping (ready for review...)
7 years, 2 months ago (2013-10-10 16:31:40 UTC) #2
scroggo
On 2013/10/10 16:31:40, epoger wrote: > ping (ready for review...) Sorry I missed it. LGTM
7 years, 2 months ago (2013-10-10 17:22:00 UTC) #3
epoger
7 years, 2 months ago (2013-10-10 17:24:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r11703 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698