Issue 2664993002: Fix Mac IA32 build breakage

Issue 2664993002: Fix Mac IA32 build breakage (Closed)

Created:
3 years, 10 months ago by Cutch

Modified:
3 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Google), Florian Schneider, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix Mac IA32 build breakage BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d6c8478c5a085162fabc45cc188edd904b586c30

Patch Set 1 #

Total comments: 1

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	runtime/vm/dart_api_impl_test.cc	View		2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

Committed patchset #1 (id:1) manually as d6c8478c5a085162fabc45cc188edd904b586c30 (presubmit successful).

3 years, 10 months ago (2017-01-30 22:10:08 UTC) #6

Florian Schneider

3 years, 10 months ago (2017-01-30 22:13:23 UTC) #7

Message was sent while issue was closed.

Lgtm.

https://codereview.chromium.org/2664993002/diff/1/runtime/vm/dart_api_impl_te...
File runtime/vm/dart_api_impl_test.cc (right):

https://codereview.chromium.org/2664993002/diff/1/runtime/vm/dart_api_impl_te...
runtime/vm/dart_api_impl_test.cc:7163:
EXPECT_EQ(static_cast<intptr_t>(0xDEADBEEF), *static_cast<intptr_t*>(peer));
I think the l-suffix should work, but have not confirmed it: 0xDEADBEEFl

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages