Mark Layer Damaged When The Client Is Gone

cc/layers/video_frame_provider_client_impl_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/macros.h"
 #include "cc/layers/video_frame_provider_client_impl.h"
 #include "cc/layers/video_layer_impl.h"
 #include "cc/output/begin_frame_args.h"
 #include "cc/test/fake_video_frame_provider.h"
 #include "cc/test/layer_test_common.h"
@@ skipping 84 matching lines @@
 
  private:
   DISALLOW_COPY_AND_ASSIGN(VideoFrameProviderClientImplTest);
 };
 
 TEST_F(VideoFrameProviderClientImplTest, StartStopRendering) {
   StartRendering();
   StopRendering();
 }
 
+TEST_F(VideoFrameProviderClientImplTest, StopRenderingUpdateDamage) {
+  CreateActiveVideoLayer();
+  StartRendering();
+  EXPECT_EQ(gfx::Rect(), video_layer_impl_->update_rect());
+  StopRendering();

[danakj, 2017/02/01 17:52:09]

Can you also stop before start and see no damage happens?

Can you also test StopUsingProvider()?

[qiangchen, 2017/02/01 18:51:59]

That does not work, because in StopRendering there is a DCHECK(rendering_),
which will fail the test.

Added test on StopUsingProvider

+  EXPECT_NE(gfx::Rect(), video_layer_impl_->update_rect());
+}
+
 TEST_F(VideoFrameProviderClientImplTest, StopUsingProvider) {
   ASSERT_TRUE(client_impl_->get_provider_for_testing());
   StartRendering();
   EXPECT_CALL(*this, RemoveVideoFrameController(_));
   client_impl_->StopUsingProvider();
   ASSERT_FALSE(client_impl_->get_provider_for_testing());
 }
 
 TEST_F(VideoFrameProviderClientImplTest, FrameAcquisition) {
   CreateActiveVideoLayer();
@@ skipping 19 matching lines @@
 TEST_F(VideoFrameProviderClientImplTest, DidDrawFrameIssuesPutCurrentFrame) {
   CreateActiveVideoLayer();
   StartRenderingAndRenderFrame();
   EXPECT_EQ(0, provider_.put_current_frame_count());
   client_impl_->DidDrawFrame();
   EXPECT_EQ(1, provider_.put_current_frame_count());
   StopRendering();
 }
 
 }  // namespace cc