Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: pkg/polymer_expressions/lib/polymer_expressions.dart

Issue 26649002: Fix bug in polymer expressions where input-value bindings are incorrectly (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer_expressions/lib/polymer_expressions.dart
diff --git a/pkg/polymer_expressions/lib/polymer_expressions.dart b/pkg/polymer_expressions/lib/polymer_expressions.dart
index e7148ad98be8ebce9e7b83f23d109da3929588a1..e5dbb7d498d119c20d641b5788a24660e9438de3 100644
--- a/pkg/polymer_expressions/lib/polymer_expressions.dart
+++ b/pkg/polymer_expressions/lib/polymer_expressions.dart
@@ -124,7 +124,6 @@ class _Binding extends Object with ChangeNotifierMixin {
set value(v) {
try {
assign(_expr, v, _scope);
- notifyChange(new PropertyChangeRecord(_VALUE));
Siggi Cherem (dart-lang) 2013/10/09 03:25:54 to clarify: - a change in the input element will u
justinfagnani 2013/10/09 19:00:59 I think I tried removing this and ran into other i
Jennifer Messerly 2013/10/09 19:04:37 probably the right fix is: try { var oldValue =
} on EvalException catch (e) {
// silently swallow binding errors
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698