Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 2664873002: Add logdog_helper script. (Closed)
Patch Set: Add logdog_helper script. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/local/device/local_device_instrumentation_test_run.py
diff --git a/build/android/pylib/local/device/local_device_instrumentation_test_run.py b/build/android/pylib/local/device/local_device_instrumentation_test_run.py
index 645b1282ae8932d4522ddf4d1b995882502afbbb..5b67b9f9a01675b1d46e7fb46d5f232afd64d4be 100644
--- a/build/android/pylib/local/device/local_device_instrumentation_test_run.py
+++ b/build/android/pylib/local/device/local_device_instrumentation_test_run.py
@@ -17,6 +17,7 @@ from pylib.base import base_test_result
from pylib.instrumentation import instrumentation_test_instance
from pylib.local.device import local_device_environment
from pylib.local.device import local_device_test_run
+from pylib.utils import logdog_helper
from py_trace_event import trace_event
from py_utils import contextlib_ext
import tombstones
@@ -285,7 +286,7 @@ class LocalDeviceInstrumentationTestRun(
results = self._test_instance.GenerateTestResults(
result_code, result_bundle, statuses, start_ms, duration_ms)
for result in results:
- result.SetLogcatUrl(logcat_url)
+ result.SetLink('logcat', logcat_url)
# Update the result name if the test used flags.
if flags:
@@ -357,9 +358,9 @@ class LocalDeviceInstrumentationTestRun(
stream_name = 'tombstones_%s_%s' % (
time.strftime('%Y%m%dT%H%M%S', time.localtime()),
device.serial)
- tombstones_url = tombstones.LogdogTombstones(resolved_tombstones,
jbudorick 2017/01/31 23:15:12 Can you remove tombstones.LogdogTombstones with th
mikecase (-- gone --) 2017/02/01 22:13:45 Yes. And I thought I had done this. But I must hav
- stream_name)
- result.SetTombstonesUrl(tombstones_url)
+ tombstones_url = logdog_helper.text(
+ stream_name, resolved_tombstones)
+ result.AddLink('tombstones', tombstones_url)
return results, None
#override

Powered by Google App Engine
This is Rietveld 408576698