Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: build/android/pylib/local/device/local_device_gtest_run.py

Issue 2664873002: Add logdog_helper script. (Closed)
Patch Set: Update one use of AddLink to SetLink I missed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/local/device/local_device_gtest_run.py
diff --git a/build/android/pylib/local/device/local_device_gtest_run.py b/build/android/pylib/local/device/local_device_gtest_run.py
index 040e93a2f8ef86ab1d41a84ea4891625b0b290a1..82da53546278d9ae7e8859d07a9a60e9033f4c86 100644
--- a/build/android/pylib/local/device/local_device_gtest_run.py
+++ b/build/android/pylib/local/device/local_device_gtest_run.py
@@ -19,6 +19,7 @@ from pylib.gtest import gtest_test_instance
from pylib.local import local_test_server_spawner
from pylib.local.device import local_device_environment
from pylib.local.device import local_device_test_run
+from pylib.utils import logdog_helper
from py_trace_event import trace_event
from py_utils import contextlib_ext
import tombstones
@@ -433,9 +434,9 @@ class LocalDeviceGtestRun(local_device_test_run.LocalDeviceTestRun):
stream_name = 'tombstones_%s_%s' % (
time.strftime('%Y%m%dT%H%M%S', time.localtime()),
device.serial)
- tombstones_url = tombstones.LogdogTombstones(resolved_tombstones,
- stream_name)
- result.SetTombstonesUrl(tombstones_url)
+ tombstones_url = logdog_helper.text(
+ stream_name, resolved_tombstones)
+ result.SetLink('tombstones', tombstones_url)
not_run_tests = set(test).difference(set(r.GetName() for r in results))
return results, list(not_run_tests) if results else None

Powered by Google App Engine
This is Rietveld 408576698