Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2765)

Unified Diff: extensions/browser/value_store/value_store_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/value_store/value_store_unittest.cc
diff --git a/extensions/browser/value_store/value_store_unittest.cc b/extensions/browser/value_store/value_store_unittest.cc
index 9d332d7c4d9afe7e4afb09b259456a152f9f7c0b..d3dfba3b417f5a9b8c935f89376e94299ba01f99 100644
--- a/extensions/browser/value_store/value_store_unittest.cc
+++ b/extensions/browser/value_store/value_store_unittest.cc
@@ -133,9 +133,9 @@ ValueStoreTest::ValueStoreTest()
dict123_(new base::DictionaryValue()),
ui_thread_(BrowserThread::UI, base::MessageLoop::current()),
file_thread_(BrowserThread::FILE, base::MessageLoop::current()) {
- val1_.reset(new base::StringValue(key1_ + "Value"));
- val2_.reset(new base::StringValue(key2_ + "Value"));
- val3_.reset(new base::StringValue(key3_ + "Value"));
+ val1_.reset(new base::Value(key1_ + "Value"));
+ val2_.reset(new base::Value(key2_ + "Value"));
+ val3_.reset(new base::Value(key3_ + "Value"));
list1_.push_back(key1_);
list2_.push_back(key2_);
@@ -330,7 +330,7 @@ TEST_P(ValueStoreTest, ClearWhenNotEmpty) {
// indexing into a dictionary.
TEST_P(ValueStoreTest, DotsInKeyNames) {
std::string dot_key("foo.bar");
- base::StringValue dot_value("baz.qux");
+ base::Value dot_value("baz.qux");
std::vector<std::string> dot_list;
dot_list.push_back(dot_key);
base::DictionaryValue dot_dict;
« no previous file with comments | « extensions/browser/value_store/value_store_frontend_unittest.cc ('k') | extensions/common/event_filter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698