Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: content/browser/appcache/appcache_internals_ui.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/appcache/appcache_internals_ui.cc
diff --git a/content/browser/appcache/appcache_internals_ui.cc b/content/browser/appcache/appcache_internals_ui.cc
index 28f33e71d756bdd11e5ded2fda08caac9af20838..e9ad038d9f8fa7fadcc379c5b51299f113c87a7b 100644
--- a/content/browser/appcache/appcache_internals_ui.cc
+++ b/content/browser/appcache/appcache_internals_ui.cc
@@ -422,7 +422,7 @@ void AppCacheInternalsUI::OnAllAppCacheInfoReady(
incognito_path_prefix = "Incognito ";
web_ui()->CallJavascriptFunctionUnsafe(
kFunctionOnAllAppCacheInfoReady,
- base::StringValue(incognito_path_prefix + partition_path.AsUTF8Unsafe()),
+ base::Value(incognito_path_prefix + partition_path.AsUTF8Unsafe()),
*GetListValueFromAppCacheInfoCollection(collection.get()));
}
@@ -432,8 +432,8 @@ void AppCacheInternalsUI::OnAppCacheInfoDeleted(
bool deleted) {
web_ui()->CallJavascriptFunctionUnsafe(
kFunctionOnAppCacheInfoDeleted,
- base::StringValue(partition_path.AsUTF8Unsafe()),
- base::StringValue(manifest_url), base::Value(deleted));
+ base::Value(partition_path.AsUTF8Unsafe()), base::Value(manifest_url),
+ base::Value(deleted));
}
void AppCacheInternalsUI::OnAppCacheDetailsReady(
@@ -442,13 +442,13 @@ void AppCacheInternalsUI::OnAppCacheDetailsReady(
std::unique_ptr<AppCacheResourceInfoVector> resource_info_vector) {
if (resource_info_vector) {
web_ui()->CallJavascriptFunctionUnsafe(
- kFunctionOnAppCacheDetailsReady, base::StringValue(manifest_url),
- base::StringValue(partition_path.AsUTF8Unsafe()),
+ kFunctionOnAppCacheDetailsReady, base::Value(manifest_url),
+ base::Value(partition_path.AsUTF8Unsafe()),
*GetListValueForAppCacheResourceInfoVector(resource_info_vector.get()));
} else {
web_ui()->CallJavascriptFunctionUnsafe(
- kFunctionOnAppCacheDetailsReady, base::StringValue(manifest_url),
- base::StringValue(partition_path.AsUTF8Unsafe()));
+ kFunctionOnAppCacheDetailsReady, base::Value(manifest_url),
+ base::Value(partition_path.AsUTF8Unsafe()));
}
}
@@ -487,7 +487,7 @@ void AppCacheInternalsUI::OnFileDetailsReady(
web_ui()->CallJavascriptFunctionUnsafe(
kFunctionOnFileDetailsReady,
*GetDictionaryValueForResponseEnquiry(response_enquiry),
- base::StringValue(headers), base::StringValue(hex_dump));
+ base::Value(headers), base::Value(hex_dump));
}
void AppCacheInternalsUI::OnFileDetailsFailed(
« no previous file with comments | « content/browser/accessibility/accessibility_ui.cc ('k') | content/browser/devtools/devtools_http_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698