components/policy/core/common/mac_util.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/mac_util.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/common/mac_util.cc

diff --git a/components/policy/core/common/mac_util.cc b/components/policy/core/common/mac_util.cc

index dd06e1ee49043791fd11c002858a1c1ab96c332b..04167e00a1e78877a85d70b411e20c210e1f254f 100644

--- a/components/policy/core/common/mac_util.cc

+++ b/components/policy/core/common/mac_util.cc

@@ -71,7 +71,7 @@ std::unique_ptr<base::Value> PropertyToValue(CFPropertyListRef property) {

if (CFStringRef string = CFCast<CFStringRef>(property)) {

return std::unique_ptr<base::Value>(

- new base::StringValue(base::SysCFStringRefToUTF8(string)));

+ new base::Value(base::SysCFStringRefToUTF8(string)));

}

if (CFDictionaryRef dict = CFCast<CFDictionaryRef>(property)) {