Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: chrome/browser/prefs/session_startup_pref_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/session_startup_pref_unittest.cc
diff --git a/chrome/browser/prefs/session_startup_pref_unittest.cc b/chrome/browser/prefs/session_startup_pref_unittest.cc
index 0f0470a777a8427faf4db5121597cff21885534d..ebe69c2b3436a87bcbfcc681b1dd43e059d9a1a1 100644
--- a/chrome/browser/prefs/session_startup_pref_unittest.cc
+++ b/chrome/browser/prefs/session_startup_pref_unittest.cc
@@ -27,8 +27,8 @@ class SessionStartupPrefTest : public testing::Test {
TEST_F(SessionStartupPrefTest, URLListIsFixedUp) {
base::ListValue* url_pref_list = new base::ListValue;
- url_pref_list->Set(0, new base::StringValue("google.com"));
- url_pref_list->Set(1, new base::StringValue("chromium.org"));
+ url_pref_list->Set(0, new base::Value("google.com"));
+ url_pref_list->Set(1, new base::Value("chromium.org"));
pref_service_->SetUserPref(prefs::kURLsToRestoreOnStartup, url_pref_list);
SessionStartupPref result =
@@ -40,13 +40,13 @@ TEST_F(SessionStartupPrefTest, URLListIsFixedUp) {
TEST_F(SessionStartupPrefTest, URLListManagedOverridesUser) {
base::ListValue* url_pref_list1 = new base::ListValue;
- url_pref_list1->Set(0, new base::StringValue("chromium.org"));
+ url_pref_list1->Set(0, new base::Value("chromium.org"));
pref_service_->SetUserPref(prefs::kURLsToRestoreOnStartup, url_pref_list1);
base::ListValue* url_pref_list2 = new base::ListValue;
- url_pref_list2->Set(0, new base::StringValue("chromium.org"));
- url_pref_list2->Set(1, new base::StringValue("chromium.org"));
- url_pref_list2->Set(2, new base::StringValue("chromium.org"));
+ url_pref_list2->Set(0, new base::Value("chromium.org"));
+ url_pref_list2->Set(1, new base::Value("chromium.org"));
+ url_pref_list2->Set(2, new base::Value("chromium.org"));
pref_service_->SetManagedPref(prefs::kURLsToRestoreOnStartup,
url_pref_list2);

Powered by Google App Engine
This is Rietveld 408576698