Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1748)

Unified Diff: chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
diff --git a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
index 1811306000fc18dcfc0bc2486f81c1ba535a0ac9..62166509cb517b8c5b5a2043c96061199416145e 100644
--- a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
+++ b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
@@ -802,7 +802,7 @@ void ChromeUserManagerImpl::SupervisedUserLoggedIn(
// Add the user to the front of the user list.
ListPrefUpdate prefs_users_update(GetLocalState(), kRegularUsers);
prefs_users_update->Insert(
- 0, base::MakeUnique<base::StringValue>(account_id.GetUserEmail()));
+ 0, base::MakeUnique<base::Value>(account_id.GetUserEmail()));
users_.insert(users_.begin(), active_user_);
// Now that user is in the list, save display name.
@@ -1260,20 +1260,20 @@ void ChromeUserManagerImpl::SetUserAffiliation(
bool ChromeUserManagerImpl::ShouldReportUser(const std::string& user_id) const {
const base::ListValue& reporting_users =
*(GetLocalState()->GetList(kReportingUsers));
- base::StringValue user_id_value(FullyCanonicalize(user_id));
+ base::Value user_id_value(FullyCanonicalize(user_id));
return !(reporting_users.Find(user_id_value) == reporting_users.end());
}
void ChromeUserManagerImpl::AddReportingUser(const AccountId& account_id) {
ListPrefUpdate users_update(GetLocalState(), kReportingUsers);
users_update->AppendIfNotPresent(
- base::MakeUnique<base::StringValue>(account_id.GetUserEmail()));
+ base::MakeUnique<base::Value>(account_id.GetUserEmail()));
}
void ChromeUserManagerImpl::RemoveReportingUser(const AccountId& account_id) {
ListPrefUpdate users_update(GetLocalState(), kReportingUsers);
users_update->Remove(
- base::StringValue(FullyCanonicalize(account_id.GetUserEmail())), NULL);
+ base::Value(FullyCanonicalize(account_id.GetUserEmail())), NULL);
}
void ChromeUserManagerImpl::UpdateLoginState(

Powered by Google App Engine
This is Rietveld 408576698