Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2664743002: Make __DATE__, __TIME__ and __TIMESTAMP__ to evaluate to an empty string. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 ":compiler_cpu_abi", 173 ":compiler_cpu_abi",
174 ":compiler_codegen", 174 ":compiler_codegen",
175 ] 175 ]
176 176
177 # In general, Windows is totally different, but all the other builds share 177 # In general, Windows is totally different, but all the other builds share
178 # some common GCC configuration. 178 # some common GCC configuration.
179 if (!is_win) { 179 if (!is_win) {
180 # Common GCC compiler flags setup. 180 # Common GCC compiler flags setup.
181 # -------------------------------- 181 # --------------------------------
182 cflags += [ "-fno-strict-aliasing" ] # See http://crbug.com/32204 182 cflags += [ "-fno-strict-aliasing" ] # See http://crbug.com/32204
183
184 # Eliminate build metadata (__DATE__, __TIME__ and __TIMESTAMP__) for
185 # deterministic build. See https://crbug.com/314403
186 cflags += [
187 "-Wno-builtin-macro-redefined",
188 "-D__DATE__=",
189 "-D__TIME__=",
190 "-D__TIMESTAMP__=",
191 ]
192
Nico 2017/01/31 01:27:56 Don't we want this on Windows too?
Yoshisato Yanagisawa 2017/02/01 07:56:50 Done.
183 cflags_cc += [ 193 cflags_cc += [
184 # If this is removed then remove the corresponding /Zc:threadSafeInit- for 194 # If this is removed then remove the corresponding /Zc:threadSafeInit- for
185 # Windows. 195 # Windows.
186 "-fno-threadsafe-statics", 196 "-fno-threadsafe-statics",
187 197
188 # Not exporting C++ inline functions can generally be applied anywhere 198 # Not exporting C++ inline functions can generally be applied anywhere
189 # so we do so here. Normal function visibility is controlled by 199 # so we do so here. Normal function visibility is controlled by
190 # //build/config/gcc:symbol_visibility_hidden. 200 # //build/config/gcc:symbol_visibility_hidden.
191 "-fvisibility-inlines-hidden", 201 "-fvisibility-inlines-hidden",
192 ] 202 ]
(...skipping 1486 matching lines...) Expand 10 before | Expand all | Expand 10 after
1679 1689
1680 if (is_ios || is_mac) { 1690 if (is_ios || is_mac) {
1681 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1691 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1682 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1692 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1683 config("enable_arc") { 1693 config("enable_arc") {
1684 common_flags = [ "-fobjc-arc" ] 1694 common_flags = [ "-fobjc-arc" ]
1685 cflags_objc = common_flags 1695 cflags_objc = common_flags
1686 cflags_objcc = common_flags 1696 cflags_objcc = common_flags
1687 } 1697 }
1688 } 1698 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698