Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 266473003: Mark HTMLMediaElement/MediaController.duration as unrestricted double (Closed)

Created:
6 years, 7 months ago by philipj_slow
Modified:
6 years, 7 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, philipj_slow, gasubic, fs, eric.carlson_apple.com, vcarbune.chromium, feature-media-reviews_chromium.org, dglazkov+blink, nessy, Inactive, watchdog-blink-watchlist_google.com, adamk+blink_chromium.org
Visibility:
Public.

Description

Mark HTMLMediaElement/MediaController.duration as unrestricted double This does not change the generated code, it is only to match the spec: http://whatwg.org/html#htmlmediaelement http://whatwg.org/html#mediacontroller BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/html/HTMLMediaElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaController.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
philipj_slow
6 years, 7 months ago (2014-04-30 11:32:09 UTC) #1
fs
LGTM
6 years, 7 months ago (2014-04-30 11:39:25 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-04-30 11:42:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/266473003/1
6 years, 7 months ago (2014-04-30 11:42:31 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 12:07:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink
6 years, 7 months ago (2014-04-30 12:07:15 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-04-30 12:17:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/266473003/1
6 years, 7 months ago (2014-04-30 12:17:59 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 14:55:22 UTC) #9
Message was sent while issue was closed.
Change committed as 172981

Powered by Google App Engine
This is Rietveld 408576698