Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2924)

Unified Diff: ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Issue 2664683002: ash: Drop the immediately following power button released induced forcing off request (Closed)
Patch Set: comments from ps2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/chromeos/power/tablet_power_button_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
diff --git a/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc b/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
index 2dcc5ece2e72ddadc54012374e8765736ae29afd..546c86121c65e842358446a28cfd5456ece5b887 100644
--- a/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
+++ b/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
@@ -439,5 +439,40 @@ TEST_F(TabletPowerButtonControllerTest,
EXPECT_FALSE(GetBacklightsForcedOff());
}
+// Tests that repeated power button releases are ignored (crbug.com/675291).
+TEST_F(TabletPowerButtonControllerTest, IgnoreRepeatedPowerButtonReleases) {
+ // Advance a long duration from initialized last resume time in
+ // |tablet_controller_| to avoid cross interference.
+ tick_clock_->Advance(base::TimeDelta::FromMilliseconds(2000));
+
+ // Set backlights forced off for starting point.
+ PressPowerButton();
+ ReleasePowerButton();
+ power_manager_client_->SendBrightnessChanged(0, false);
+ EXPECT_TRUE(GetBacklightsForcedOff());
+
+ // Test that a pressing-releasing operation after a short duration, backlights
+ // forced off is stopped since we don't drop request for power button pressed.
+ tick_clock_->Advance(base::TimeDelta::FromMilliseconds(200));
+ power_manager_client_->SendPowerButtonEvent(true, tick_clock_->NowTicks());
+ power_manager_client_->SendBrightnessChanged(kNonZeroBrightness, false);
+ power_manager_client_->SendPowerButtonEvent(false, tick_clock_->NowTicks());
+ EXPECT_FALSE(GetBacklightsForcedOff());
+
+ // Test that after another short duration, backlights will not be forced off
+ // since this immediately following forcing off request needs to be dropped.
+ tick_clock_->Advance(base::TimeDelta::FromMilliseconds(200));
+ power_manager_client_->SendPowerButtonEvent(true, tick_clock_->NowTicks());
+ power_manager_client_->SendPowerButtonEvent(false, tick_clock_->NowTicks());
+ EXPECT_FALSE(GetBacklightsForcedOff());
+
+ // Test that after another long duration, backlights should be forced off.
+ tick_clock_->Advance(base::TimeDelta::FromMilliseconds(800));
+ power_manager_client_->SendPowerButtonEvent(true, tick_clock_->NowTicks());
+ power_manager_client_->SendPowerButtonEvent(false, tick_clock_->NowTicks());
+ power_manager_client_->SendBrightnessChanged(0, false);
+ EXPECT_TRUE(GetBacklightsForcedOff());
+}
+
} // namespace test
} // namespace ash
« no previous file with comments | « ash/system/chromeos/power/tablet_power_button_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698