Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2664643002: fix #28519, assertion incorrectly triggering (Closed)

Created:
3 years, 10 months ago by Jennifer Messerly
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M pkg/analyzer/lib/src/dart/element/type.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jennifer Messerly
3 years, 10 months ago (2017-01-29 06:56:06 UTC) #2
scheglov
lgtm
3 years, 10 months ago (2017-01-29 08:21:04 UTC) #4
Jennifer Messerly
3 years, 10 months ago (2017-01-29 08:26:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
4974b71709718e7c917993cbdb871051eb7f69dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698