Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2664603002: Remove replaceComposition() calls in finishComposingText. (Closed)
Patch Set: Clean up Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 6a7688b4817567c722a4bd8a62bdb8d39f05bc73..5a2569f7bef7989d5b2927a74ea4ecb248e68cd4 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -2297,12 +2297,6 @@ void WebViewImpl::setFocus(bool enable) {
if (focusedFrame) {
// Finish an ongoing composition to delete the composition node.
if (focusedFrame->inputMethodController().hasComposition()) {
- WebAutofillClient* autofillClient =
- WebLocalFrameImpl::fromFrame(focusedFrame)->autofillClient();
-
- if (autofillClient)
- autofillClient->setIgnoreTextChanges(true);
-
// TODO(xiaochengh): The use of
// updateStyleAndLayoutIgnorePendingStylesheets
// needs to be audited. See http://crbug.com/590369 for more details.
@@ -2311,9 +2305,6 @@ void WebViewImpl::setFocus(bool enable) {
focusedFrame->inputMethodController().finishComposingText(
InputMethodController::KeepSelection);
-
- if (autofillClient)
- autofillClient->setIgnoreTextChanges(false);
}
m_imeAcceptEvents = false;
}

Powered by Google App Engine
This is Rietveld 408576698