MetricsService: Send a hash of the UMA log in a header.

chrome/common/metrics/metrics_log_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "chrome/common/metrics/metrics_log_manager.h"
+
 #include <string>
 #include <utility>
 #include <vector>
 
+#include "base/sha1.h"
 #include "chrome/common/metrics/metrics_log_base.h"
-#include "chrome/common/metrics/metrics_log_manager.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
-class MetricsLogManagerTest : public testing::Test {
-};
+typedef testing::Test MetricsLogManagerTest;

[Ilya Sherman, 2013/10/17 22:06:25]

nit: You can just remove this, and change all the TEST_F macros to TEST macros
instead.

[Alexei Svitkine (slow), 2013/10/18 18:51:06]

Done.

 
 // Dummy serializer that just stores logs in memory.
 class DummyLogSerializer : public MetricsLogManager::LogSerializer {
  public:
-  virtual void SerializeLogs(const std::vector<std::string>& logs,
-                             MetricsLogManager::LogType log_type) OVERRIDE {
+  virtual void SerializeLogs(
+      const std::vector<MetricsLogManager::SerializedLog>& logs,
+      MetricsLogManager::LogType log_type) OVERRIDE {
     persisted_logs_[log_type] = logs;
   }
 
-  virtual void DeserializeLogs(MetricsLogManager::LogType log_type,
-                               std::vector<std::string>* logs) OVERRIDE {
+  virtual void DeserializeLogs(
+      MetricsLogManager::LogType log_type,
+      std::vector<MetricsLogManager::SerializedLog>* logs) OVERRIDE {
     ASSERT_NE(static_cast<void*>(NULL), logs);
     *logs = persisted_logs_[log_type];
   }
 
   // Returns the number of logs of the given type.
   size_t TypeCount(MetricsLogManager::LogType log_type) {
     return persisted_logs_[log_type].size();
   }
 
   // In-memory "persitent storage".
-  std::vector<std::string> persisted_logs_[2];
+  std::vector<MetricsLogManager::SerializedLog> persisted_logs_[2];
 };
 
 }  // namespace
 
 TEST(MetricsLogManagerTest, StandardFlow) {
   MetricsLogManager log_manager;
 
   // Make sure a new manager has a clean slate.
   EXPECT_EQ(NULL, log_manager.current_log());
   EXPECT_FALSE(log_manager.has_staged_log());
@@ skipping 83 matching lines @@
   // has the right type.
   DummyLogSerializer* serializer = new DummyLogSerializer;
   log_manager.set_log_serializer(serializer);
   log_manager.FinishCurrentLog();
   log_manager.PersistUnsentLogs();
   EXPECT_EQ(0U, serializer->TypeCount(MetricsLogManager::INITIAL_LOG));
   EXPECT_EQ(1U, serializer->TypeCount(MetricsLogManager::ONGOING_LOG));
 }
 
 TEST(MetricsLogManagerTest, StoreAndLoad) {
-  std::vector<std::string> initial_logs;
-  std::vector<std::string> ongoing_logs;
+  std::vector<MetricsLogManager::SerializedLog> initial_logs;
+  std::vector<MetricsLogManager::SerializedLog> ongoing_logs;
 
   // Set up some in-progress logging in a scoped log manager simulating the
   // leadup to quitting, then persist as would be done on quit.
   {
     MetricsLogManager log_manager;
     DummyLogSerializer* serializer = new DummyLogSerializer;
     log_manager.set_log_serializer(serializer);
     // Simulate a log having already been unsent from a previous session.
-    std::string log = "proto";
+    MetricsLogManager::SerializedLog log;
+    log.SetLogText("proto");
     serializer->persisted_logs_[MetricsLogManager::ONGOING_LOG].push_back(log);
     EXPECT_FALSE(log_manager.has_unsent_logs());
     log_manager.LoadPersistedUnsentLogs();
     EXPECT_TRUE(log_manager.has_unsent_logs());
 
     MetricsLogBase* log1 = new MetricsLogBase("id", 0, "version");
     MetricsLogBase* log2 = new MetricsLogBase("id", 0, "version");
     log_manager.BeginLoggingWithLog(log1, MetricsLogManager::INITIAL_LOG);
     log_manager.FinishCurrentLog();
     log_manager.BeginLoggingWithLog(log2, MetricsLogManager::ONGOING_LOG);
@@ skipping 173 matching lines @@
     log_manager.StoreStagedLogAsUnsent(MetricsLogManager::PROVISIONAL_STORE);
     log_manager.DiscardLastProvisionalStore();
     log_manager.DiscardLastProvisionalStore();
 
     DummyLogSerializer* serializer = new DummyLogSerializer;
     log_manager.set_log_serializer(serializer);
     log_manager.PersistUnsentLogs();
     EXPECT_EQ(1U, serializer->TypeCount(MetricsLogManager::ONGOING_LOG));
   }
 }
+
+TEST(MetricsLogManagerTest, SerializedLog) {
+  const char kFooText[] = "foo";
+  const std::string foo_hash = base::SHA1HashString(kFooText);
+  const char kBarText[] = "bar";
+  const std::string bar_hash = base::SHA1HashString(kBarText);
+
+  MetricsLogManager::SerializedLog log;
+  EXPECT_TRUE(log.log_text().empty());
+  EXPECT_TRUE(log.log_hash().empty());
+
+  log.SetLogText(kFooText);
+  EXPECT_FALSE(log.IsEmpty());
+  EXPECT_EQ(kFooText, log.log_text());
+  EXPECT_EQ(foo_hash, log.log_hash());
+
+  std::string bar = kBarText;
+  log.SwapLogText(&bar);
+  EXPECT_EQ(kFooText, bar);
+  EXPECT_FALSE(log.IsEmpty());
+  EXPECT_EQ(kBarText, log.log_text());
+  EXPECT_EQ(bar_hash, log.log_hash());
+
+  log.SetLogText(std::string());
+  EXPECT_TRUE(log.IsEmpty());
+  EXPECT_TRUE(log.log_text().empty());
+  EXPECT_TRUE(log.log_hash().empty());
+
+  MetricsLogManager::SerializedLog log2;
+  log2.SetLogText(kFooText);
+  log.Swap(&log2);
+  EXPECT_FALSE(log.IsEmpty());
+  EXPECT_EQ(kFooText, log.log_text());
+  EXPECT_EQ(foo_hash, log.log_hash());
+  EXPECT_TRUE(log2.IsEmpty());
+  EXPECT_TRUE(log2.log_text().empty());
+  EXPECT_TRUE(log2.log_hash().empty());
+
+  log.Clear();
+  EXPECT_TRUE(log.IsEmpty());
+  EXPECT_TRUE(log.log_text().empty());
+  EXPECT_TRUE(log.log_hash().empty());
+}