Issue 2664543002: Complete with null, not return null as a Future.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2664543002: Complete with null, not return null as a Future. (Closed)

Created:
3 years, 10 months ago by scheglov

Modified:
3 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Complete with null, not return null as a Future. I missed the fact that these methods are not async. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3de5551cc4699eac914637e96cd60e43e2be8c41

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 10 months ago (2017-01-27 17:10:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3de5551cc4699eac914637e96cd60e43e2be8c41 (presubmit successful).