Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 266453006: Improve Android gdbserver and gdb_ex scripts (Closed)

Created:
6 years, 7 months ago by hal.canary
Modified:
6 years, 7 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Improve Android gdbserver and gdb_ex scripts - Don't complain if $GDB_TMP_DIR already exists - Since $GDB_TMP_DIR/gdb.setup might already exist, overwrite the file. NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M platform_tools/android/bin/android_gdb_exe View 1 chunk +13 lines, -9 lines 0 comments Download
M platform_tools/android/bin/android_gdbserver View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 7 months ago (2014-04-30 20:48:46 UTC) #1
hal.canary
The CQ bit was unchecked by halcanary@google.com
6 years, 7 months ago (2014-04-30 20:48:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/266453006/1
6 years, 7 months ago (2014-04-30 20:49:00 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 20:49:01 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-04-30 20:49:01 UTC) #5
hal.canary
Subset of http://crrev.com/254923003
6 years, 7 months ago (2014-05-01 13:08:58 UTC) #6
djsollen
lgtm
6 years, 7 months ago (2014-05-01 14:52:35 UTC) #7
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 7 months ago (2014-05-01 15:06:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/266453006/1
6 years, 7 months ago (2014-05-01 15:07:04 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 15:19:40 UTC) #10
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Nexus7-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
6 years, 7 months ago (2014-05-01 15:19:40 UTC) #11
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 7 months ago (2014-05-01 15:34:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/266453006/1
6 years, 7 months ago (2014-05-01 15:34:22 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 15:34:30 UTC) #14
Message was sent while issue was closed. 
Change committed as 14503

Powered by Google App Engine
This is Rietveld 408576698