Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: Source/modules/mediasource/SourceBuffer.idl

Issue 266453005: Apply TypeChecking to MediaSource IDLs (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use MAX_VALUE instead of POS_INF. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/mediasource/SourceBuffer.cpp ('k') | Source/modules/mediasource/URLMediaSource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/mediasource/SourceBuffer.idl
diff --git a/Source/modules/mediasource/SourceBuffer.idl b/Source/modules/mediasource/SourceBuffer.idl
index 971b096141dc1f0029b9296cd0436efb1ccb2003..7827d60d74bfe8f2e3e8df7744909d2bfdaecc16 100644
--- a/Source/modules/mediasource/SourceBuffer.idl
+++ b/Source/modules/mediasource/SourceBuffer.idl
@@ -39,6 +39,7 @@ enum AppendMode {
ActiveDOMObject,
NoInterfaceObject,
RuntimeEnabled=MediaSource,
+ TypeChecking=Interface|Nullable|Unrestricted,
] interface SourceBuffer : EventTarget {
// Gets or sets the AppendMode.
@@ -51,10 +52,10 @@ enum AppendMode {
[RaisesException=Getter] readonly attribute TimeRanges buffered;
// Applies an offset to media segment timestamps.
- [RaisesException=Setter, TypeChecking=Unrestricted] attribute double timestampOffset;
+ [RaisesException=Setter] attribute double timestampOffset;
// Presentation timestamp for the start of append window.
- [RaisesException=Setter, TypeChecking=Unrestricted] attribute double appendWindowStart;
+ [RaisesException=Setter] attribute double appendWindowStart;
// Presentation timestamp for the end of append window.
[RaisesException=Setter] attribute unrestricted double appendWindowEnd;
@@ -67,6 +68,8 @@ enum AppendMode {
// Abort the current segment append sequence.
[RaisesException] void abort();
+ // Pending W3C bug: "Change SourceBuffer.remove() end parameter to 'unrestricted double'",
+ // https://www.w3.org/Bugs/Public/show_bug.cgi?id=25518
[RaisesException] void remove(double start, double end);
};
« no previous file with comments | « Source/modules/mediasource/SourceBuffer.cpp ('k') | Source/modules/mediasource/URLMediaSource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698