Source/modules/mediasource/MediaSourceBase.cpp - Issue 266453005: Apply TypeChecking to MediaSource IDLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/mediasource/MediaSourceBase.cpp

Issue 266453005: Apply TypeChecking to MediaSource IDLs (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Undo too eager removal; Fixup test; Mark remove() args unrestricted. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/mediasource/MediaSourceBase.cpp

diff --git a/Source/modules/mediasource/MediaSourceBase.cpp b/Source/modules/mediasource/MediaSourceBase.cpp

index 6662e27945da00bb6fee20e1718f84c58708e326..a4e0e531d57ac4fa5a6cb88d56b7579cb303fcab 100644

--- a/Source/modules/mediasource/MediaSourceBase.cpp

+++ b/Source/modules/mediasource/MediaSourceBase.cpp

@@ -229,7 +229,6 @@ void MediaSourceBase::endOfStream(const AtomicString& error, ExceptionState& exc

endOfStreamInternal(blink::WebMediaSource::EndOfStreamStatusDecodeError, exceptionState);

} else {

ASSERT_NOT_REACHED(); // IDL enforcement should prevent this case.

- exceptionState.throwTypeError("parameter 1 is not a valid enum value.");

}