Apply TypeChecking to MediaSource IDLs

Source/modules/mediasource/MediaSource.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 57 matching lines @@
 {
     WTF_LOG(Media, "MediaSource::~MediaSource %p", this);
     ASSERT(isClosed());
 }
 
 SourceBuffer* MediaSource::addSourceBuffer(const String& type, ExceptionState& exceptionState)
 {
     WTF_LOG(Media, "MediaSource::addSourceBuffer(%s) %p", type.ascii().data(), this);
 
     // 2.2 https://dvcs.w3.org/hg/html-media/raw-file/default/media-source/media-source.html#widl-MediaSource-addSourceBuffer-SourceBuffer-DOMString-type
-    // 1. If type is null or an empty then throw an InvalidAccessError exception and
-    // abort these steps.
-    if (type.isNull() || type.isEmpty()) {
+    // 1. If type is an empty string then throw an InvalidAccessError exception
+    // and abort these steps.
+    if (type.isEmpty()) {
         exceptionState.throwDOMException(InvalidAccessError, "The type provided is empty.");
         return 0;
     }
 
     // 2. If type contains a MIME type that is not supported ..., then throw a
     // NotSupportedError exception and abort these steps.
     if (!isTypeSupported(type)) {
         exceptionState.throwDOMException(NotSupportedError, "The type provided ('" + type + "') is unsupported.");
         return 0;
     }
@@ skipping 24 matching lines @@
     // 7. Return the new object to the caller.
     return buffer.get();
 }
 
 void MediaSource::removeSourceBuffer(SourceBuffer* buffer, ExceptionState& exceptionState)
 {
     WTF_LOG(Media, "MediaSource::removeSourceBuffer() %p", this);
     RefPtr<SourceBuffer> protect(buffer);
 
     // 2.2 https://dvcs.w3.org/hg/html-media/raw-file/default/media-source/media-source.html#widl-MediaSource-removeSourceBuffer-void-SourceBuffer-sourceBuffer
-    // 1. If sourceBuffer is null then throw an InvalidAccessError exception and
-    // abort these steps.
-    if (!buffer) {
-        exceptionState.throwDOMException(InvalidAccessError, "The SourceBuffer provided is invalid.");
-        return;
-    }
 
-    // 2. If sourceBuffer specifies an object that is not in sourceBuffers then
+    // 1. If sourceBuffer specifies an object that is not in sourceBuffers then
     // throw a NotFoundError exception and abort these steps.
     if (!m_sourceBuffers->length() || !m_sourceBuffers->contains(buffer)) {
         exceptionState.throwDOMException(NotFoundError, "The SourceBuffer provided is not contained in this MediaSource.");
         return;
     }
 
-    // 3. If the sourceBuffer.updating attribute equals true, then run the following steps: ...
+    // 2. If the sourceBuffer.updating attribute equals true, then run the following steps: ...
     buffer->abortIfUpdating();
 
-    // Steps 4-9 are related to updating audioTracks, videoTracks, and textTracks which aren't implmented yet.
+    // Steps 3-8 are related to updating audioTracks, videoTracks, and textTracks which aren't implmented yet.
     // FIXME(91649): support track selection
 
-    // 10. If sourceBuffer is in activeSourceBuffers, then remove sourceBuffer from activeSourceBuffers ...
+    // 9. If sourceBuffer is in activeSourceBuffers, then remove sourceBuffer from activeSourceBuffers ...
     m_activeSourceBuffers->remove(buffer);
 
-    // 11. Remove sourceBuffer from sourceBuffers and fire a removesourcebuffer event
+    // 10. Remove sourceBuffer from sourceBuffers and fire a removesourcebuffer event
     // on that object.
     m_sourceBuffers->remove(buffer);
 
-    // 12. Destroy all resources for sourceBuffer.
+    // 11. Destroy all resources for sourceBuffer.
     buffer->removedFromMediaSource();
 }
 
 void MediaSource::onReadyStateChange(const AtomicString& oldState, const AtomicString& newState)
 {
     if (isOpen()) {
         scheduleEvent(EventTypeNames::sourceopen);
         return;
     }
 
@@ skipping 64 matching lines @@
 }
 
 void MediaSource::trace(Visitor* visitor)
 {
     visitor->trace(m_sourceBuffers);
     visitor->trace(m_activeSourceBuffers);
     MediaSourceBase::trace(visitor);
 }
 
 } // namespace WebCore