Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2664513003: Fix Rasta to correctly identify added break targets in switch statements. (Closed)

Created:
3 years, 10 months ago by Emily Fortuna
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, sra1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Rasta to correctly identify added break targets in switch statements. This fixes the empty statement try/catch/switch test Stephen was asking about. BUG=https://github.com/dart-lang/sdk/issues/28533 R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b26135f16025ed98a6d5ce758a4eef3df339e75d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 4 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Emily Fortuna
3 years, 10 months ago (2017-01-27 21:22:09 UTC) #3
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-01-27 21:23:29 UTC) #4
Emily Fortuna
3 years, 10 months ago (2017-01-27 21:27:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b26135f16025ed98a6d5ce758a4eef3df339e75d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698