Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 26645002: IDL compiler: [DoNotCheckSecurity], [DoNotCheckSecurityOnGetter], [DoNotCheckSecurityOnSetter] (Closed)

Created:
7 years, 2 months ago by Nils Barth (inactive)
Modified:
7 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, do-not-use, kouhei (in TOK)
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Typo #

Patch Set 3 : Revised, remove [DoNotCheckSecurityOnSetter] #

Patch Set 4 : Rebase #

Patch Set 5 : Revert Perl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
M Source/bindings/scripts/unstable/v8_attributes.py View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 2 3 4 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nils Barth (inactive)
[DoNotCheckSecurityOnSetter] isn't used; do we want to remove it?
7 years, 2 months ago (2013-10-09 02:00:10 UTC) #1
haraken
On 2013/10/09 02:00:10, Nils Barth wrote: > [DoNotCheckSecurityOnSetter] isn't used; > do we want to ...
7 years, 2 months ago (2013-10-09 02:13:36 UTC) #2
Nils Barth (inactive)
On 2013/10/09 02:13:36, haraken wrote: > On 2013/10/09 02:00:10, Nils Barth wrote: > > [DoNotCheckSecurityOnSetter] ...
7 years, 2 months ago (2013-10-09 02:32:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/26645002/11001
7 years, 2 months ago (2013-10-11 09:31:54 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=7769
7 years, 2 months ago (2013-10-11 10:44:27 UTC) #5
Nils Barth (inactive)
On 2013/10/11 10:44:27, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 2 months ago (2013-10-11 14:48:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/26645002/26001
7 years, 2 months ago (2013-10-11 14:48:45 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-11 16:20:42 UTC) #8
Message was sent while issue was closed.
Change committed as 159457

Powered by Google App Engine
This is Rietveld 408576698