pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart - Issue 2664493005: Fix getFieldType to handle metadata and workaround bad types for setters called via mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart

Issue 2664493005: Fix getFieldType to handle metadata and workaround bad types for setters called via mirrors. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart

index 026eb9a1f38b127fa040afded605e91dc01eb982..e91d790839ffbc3f9cb6bedcf6afedbd65988763 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart

@@ -217,7 +217,9 @@ getFieldType(type, name) => JS(

'''(() => {

let sigObj = $type[$_fieldSig];

if (sigObj === void 0) return void 0;

- return sigObj[$name];

+ let fieldType = sigObj[$name];

+ // workaround to handle metadata.

+ return (fieldType instanceof Array) ? fieldType[0] : fieldType;

})()''');

getSetterType(type, name) => JS(