Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2664493004: Guard against FunctionExpression nodes with null parameters. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Guard against FunctionExpression nodes with null parameters. I see this exception in logs, but I was not able to find which Dart code would cause this. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/47967ac9f2f8d8c200aa8ce5594fe79d42c2931d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-01-27 18:37:10 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-01-27 19:38:01 UTC) #2
scheglov
3 years, 10 months ago (2017-01-27 19:57:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
47967ac9f2f8d8c200aa8ce5594fe79d42c2931d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698