Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2664453003: Add Uri.isScheme test function. (Closed)

Created:
3 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Uri.isScheme test function. Allows checking the scheme of a URI against a known value. Example: `uri.isScheme("http")`. Has two advantages over `uri.scheme == "http"`: * It's case insensitive, so you can do `uri.isScheme("HTTP")` as well, and * for simple URIs, it doesn't need to allocate a new string. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/dd561d513bcecb20e5995eccdd3843d529c0ec5b

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -4 lines) Patch
M CHANGELOG.md View 1 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/core/uri.dart View 1 4 chunks +60 lines, -0 lines 0 comments Download
M tests/corelib/uri_test.dart View 2 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-01-27 09:48:30 UTC) #3
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-01-27 09:48:30 UTC) #4
floitsch
LGTM. https://codereview.chromium.org/2664453003/diff/1/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/2664453003/diff/1/sdk/lib/core/uri.dart#newcode526 sdk/lib/core/uri.dart:526: /// A `null` or empty [scheme] string will ...
3 years, 10 months ago (2017-01-30 11:17:44 UTC) #5
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-01-30 12:26:35 UTC) #6
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-01-30 12:26:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dd561d513bcecb20e5995eccdd3843d529c0ec5b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698