code clean-up, issue crbug.com/260966 is fixed with

code clean-up, issue crbug.com/260966 is fixed with
https://chromiumcodereview.appspot.com/19525002 from pdr

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172954

[h.joshi, 2014-04-30 04:48:53]

Code clean-up, pls review.

[pdr., 2014-04-30 04:50:20]

LGTM! Thanks for the cleanup.

https://codereview.chromium.org/266443002/diff/1/Source/core/css/resolver/Fon...
File Source/core/css/resolver/FontBuilder.cpp (right):

https://codereview.chromium.org/266443002/diff/1/Source/core/css/resolver/Fon...
Source/core/css/resolver/FontBuilder.cpp:73: // bug "crbug.com/260966" is fixed
so uncommenting Assert
No need for this comment, lets just have the assert.

[h.joshi, 2014-04-30 04:54:51]

Thank you, comment fixed with new patch.

On 2014/04/30 04:50:20, pdr wrote:
> LGTM! Thanks for the cleanup.
> 
>
https://codereview.chromium.org/266443002/diff/1/Source/core/css/resolver/Fon...
> File Source/core/css/resolver/FontBuilder.cpp (right):
> 
>
https://codereview.chromium.org/266443002/diff/1/Source/core/css/resolver/Fon...
> Source/core/css/resolver/FontBuilder.cpp:73: // bug "crbug.com/260966" is
fixed
> so uncommenting Assert
> No need for this comment, lets just have the assert.

[h.joshi, 2014-04-30 04:54:55]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-04-30 04:55:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/h.joshi@samsung.com/266443002/20001

[commit-bot: I haz the power, 2014-04-30 05:20:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 05:20:01]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink

[h.joshi, 2014-04-30 05:30:12]

Getting following crash stack, starting to check call stack and Unit Test which
is failing

Received signal 11 SEGV_MAPERR 000000000188
#0 0x7f138e0a05d9 base::debug::StackTrace::StackTrace()
#1 0x7f138e09ff05 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f138340bcb0 <unknown>
#3 0x7f1388c69a54 WebCore::Document::frame()
#4 0x7f138a44e218 WebCore::FontBuilder::initForStyleResolve()
#5 0x7f1389e5a16d WebCore::Document::setupFontBuilder()
#6 0x7f138a479dfa WebCore::StyleResolver::styleForDocument()
#7 0x7f1389e5c50a WebCore::Document::attach()
#8 0x7f138a57d74a WebCore::DOMWindow::installNewDocument()
#9 0x7f138a6d4e0d WebCore::DocumentLoader::createWriterFor()
#10 0x7f138a6d341a WebCore::DocumentLoader::ensureWriter()
#11 0x7f138a6d3532 WebCore::DocumentLoader::commitData()
#12 0x7f138a6d1dd7 WebCore::DocumentLoader::finishedLoading()
#13 0x7f138a6d447d WebCore::DocumentLoader::maybeLoadEmpty()
#14 0x7f138a6d45c0 WebCore::DocumentLoader::startLoadingMainResource()
#15 0x7f138a6dfcbc WebCore::FrameLoader::init()
#16 0x7f1388cfdd1a WebCore::LocalFrame::init()
#17 0x7f1388cfc45b blink::WebLocalFrameImpl::initializeAsMainFrame()
#18 0x7f1388d3928f blink::WebViewImpl::setMainFrame()
#19 0x7f1388f520d6 blink::FrameTestHelpers::WebViewHelper::initialize()
#20 0x7f1388f52124 blink::FrameTestHelpers::WebViewHelper::initializeAndLoad()
#21 0x7f1388f8828c WebCore::(anonymous
namespace)::RenderTableCellDeathTest::SetUpTestCase()
#22 0x7f1389bb85af testing::TestCase::RunSetUpTestCase()
#23 0x7f1389bc0e18 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#24 0x7f1389bbc5f1 testing::internal::HandleExceptionsInMethodIfSupported<>()
#25 0x7f1389bb139a testing::TestCase::Run()
#26 0x7f1389bb5e37 testing::internal::UnitTestImpl::RunAllTests()
#27 0x7f1389bc1a87 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#28 0x7f1389bbd0af testing::internal::HandleExceptionsInMethodIfSupported<>()
#29 0x7f1389bb4e25 testing::UnitTest::Run()
#30 0x7f1389b6eb3b RUN_ALL_TESTS()
#31 0x7f1389b6e654 base::TestSuite::Run()
#32 0x7f13890caf1e blink::RunAllUnitTests()
#33 0x0000004642ce main
#34 0x7f138305d76d __libc_start_main
#35 0x0000004641e9 <unknown>
  r8: 0000000000000070  r9: 00007f138317e230 r10: 0000000000000000 r11:
00007f13831bf6d0
 r12: 00007f1389e5c3c2 r13: 00007fff41ba5450 r14: 0000000000000000 r15:
0000000000000000
  di: 0000000000000000  si: 0000351d1ba04010  bp: 00007fff41ba3ff0  bx:
0000000000000000
  dx: 000028a95aecc1c0  ax: 0000000000000000  cx: 0000000000000000  sp:
00007fff41ba3ff0
  ip: 00007f1388c69a54 efl: 0000000000010206 cgf: 0000000000000033 erf:
0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000188



On 2014/04/30 05:20:01, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_blink_dbg on tryserver.blink

[h.joshi, 2014-04-30 05:30:59]

I did not faced this while running Layout Test on my machine.

On 2014/04/30 05:30:12, h.joshi wrote:
> Getting following crash stack, starting to check call stack and Unit Test
which
> is failing
> 
> Received signal 11 SEGV_MAPERR 000000000188
> #0 0x7f138e0a05d9 base::debug::StackTrace::StackTrace()
> #1 0x7f138e09ff05 base::debug::(anonymous namespace)::StackDumpSignalHandler()
> #2 0x7f138340bcb0 <unknown>
> #3 0x7f1388c69a54 WebCore::Document::frame()
> #4 0x7f138a44e218 WebCore::FontBuilder::initForStyleResolve()
> #5 0x7f1389e5a16d WebCore::Document::setupFontBuilder()
> #6 0x7f138a479dfa WebCore::StyleResolver::styleForDocument()
> #7 0x7f1389e5c50a WebCore::Document::attach()
> #8 0x7f138a57d74a WebCore::DOMWindow::installNewDocument()
> #9 0x7f138a6d4e0d WebCore::DocumentLoader::createWriterFor()
> #10 0x7f138a6d341a WebCore::DocumentLoader::ensureWriter()
> #11 0x7f138a6d3532 WebCore::DocumentLoader::commitData()
> #12 0x7f138a6d1dd7 WebCore::DocumentLoader::finishedLoading()
> #13 0x7f138a6d447d WebCore::DocumentLoader::maybeLoadEmpty()
> #14 0x7f138a6d45c0 WebCore::DocumentLoader::startLoadingMainResource()
> #15 0x7f138a6dfcbc WebCore::FrameLoader::init()
> #16 0x7f1388cfdd1a WebCore::LocalFrame::init()
> #17 0x7f1388cfc45b blink::WebLocalFrameImpl::initializeAsMainFrame()
> #18 0x7f1388d3928f blink::WebViewImpl::setMainFrame()
> #19 0x7f1388f520d6 blink::FrameTestHelpers::WebViewHelper::initialize()
> #20 0x7f1388f52124 blink::FrameTestHelpers::WebViewHelper::initializeAndLoad()
> #21 0x7f1388f8828c WebCore::(anonymous
> namespace)::RenderTableCellDeathTest::SetUpTestCase()
> #22 0x7f1389bb85af testing::TestCase::RunSetUpTestCase()
> #23 0x7f1389bc0e18
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> #24 0x7f1389bbc5f1 testing::internal::HandleExceptionsInMethodIfSupported<>()
> #25 0x7f1389bb139a testing::TestCase::Run()
> #26 0x7f1389bb5e37 testing::internal::UnitTestImpl::RunAllTests()
> #27 0x7f1389bc1a87
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> #28 0x7f1389bbd0af testing::internal::HandleExceptionsInMethodIfSupported<>()
> #29 0x7f1389bb4e25 testing::UnitTest::Run()
> #30 0x7f1389b6eb3b RUN_ALL_TESTS()
> #31 0x7f1389b6e654 base::TestSuite::Run()
> #32 0x7f13890caf1e blink::RunAllUnitTests()
> #33 0x0000004642ce main
> #34 0x7f138305d76d __libc_start_main
> #35 0x0000004641e9 <unknown>
>   r8: 0000000000000070  r9: 00007f138317e230 r10: 0000000000000000 r11:
> 00007f13831bf6d0
>  r12: 00007f1389e5c3c2 r13: 00007fff41ba5450 r14: 0000000000000000 r15:
> 0000000000000000
>   di: 0000000000000000  si: 0000351d1ba04010  bp: 00007fff41ba3ff0  bx:
> 0000000000000000
>   dx: 000028a95aecc1c0  ax: 0000000000000000  cx: 0000000000000000  sp:
> 00007fff41ba3ff0
>   ip: 00007f1388c69a54 efl: 0000000000010206 cgf: 0000000000000033 erf:
> 0000000000000004
>  trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000188
> 
> 
> 
> On 2014/04/30 05:20:01, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   linux_blink_dbg on tryserver.blink

[h.joshi, 2014-04-30 06:25:08]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-04-30 06:25:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/h.joshi@samsung.com/266443002/40001

[commit-bot: I haz the power, 2014-04-30 07:29:47]

Change committed as 172954