Use pixel coordinates for shadow underlay bounds

components/exo/shell_surface.h

Index: components/exo/shell_surface.h
diff --git a/components/exo/shell_surface.h b/components/exo/shell_surface.h
index 6a85feb62f533f0e084c71e5893a7a9d59777e95..69a33669f3f13e859b49dba34af6ffe0aa7fc498 100644
--- a/components/exo/shell_surface.h
+++ b/components/exo/shell_surface.h
@@ -147,12 +147,18 @@ class ShellSurface : public SurfaceDelegate,
   // for the surface from the user's perspective.
   void SetGeometry(const gfx::Rect& geometry);
 
-  // Enable/disable rectangular shadow.
-  void SetRectangularShadow(bool enabled);
+  // Enable/disable rectangular shadow that uses the widget bounds as a content
+  // bounds.
+  void SetEnableRectangularShadow(bool enabled);

[reveman, 2017/02/06 22:38:03]

nit: SetRectangularShadowEnabled

[oshima, 2017/02/07 02:21:45]

Done.

 
-  // Set the content bounds for the shadow. Shell surface geometry will be
+  // [Deprecated] Set the content bounds for the shadow. Shell surface geometry
+  // will be
   // used if bounds are empty.
-  void SetRectangularShadowContentBounds(const gfx::Rect& content_bounds);
+  void SetRectangularShadow_DEPRECATED(const gfx::Rect& content_bounds);
+
+  // Set the content bounds for the shadow in the surface's coordinates.
+  // Setting empty bounds will disable the shadow.
+  void SetRectangularSurfaceShadow(const gfx::Rect& content_bounds);
 
   // Set the pacity of the background for the window that has a shadow.
   void SetRectangularShadowBackgroundOpacity(float opacity);
@@ -240,6 +246,7 @@ class ShellSurface : public SurfaceDelegate,
 
   aura::Window* shadow_overlay() { return shadow_overlay_; }
   aura::Window* shadow_underlay() { return shadow_underlay_; }
+  Surface* surface() { return surface_; }

[reveman, 2017/02/06 22:38:03]

nit: surface_for_testing() and blank line between shadow_underlay() and this.

[oshima, 2017/02/07 02:21:45]

Done.

 
  private:
   class ScopedConfigure;
@@ -321,6 +328,7 @@ class ShellSurface : public SurfaceDelegate,
   std::unique_ptr<ScopedAnimationsDisabled> scoped_animations_disabled_;
   int top_inset_height_ = 0;
   int pending_top_inset_height_ = 0;
+  bool shadow_underlay_in_surface_ = true;
 
   DISALLOW_COPY_AND_ASSIGN(ShellSurface);
 };