Use pixel coordinates for shadow underlay bounds

components/exo/shell_surface.h

Index: components/exo/shell_surface.h
diff --git a/components/exo/shell_surface.h b/components/exo/shell_surface.h
index 6a85feb62f533f0e084c71e5893a7a9d59777e95..d1dc019b94b8402953e7609f4843304cb7039a44 100644
--- a/components/exo/shell_surface.h
+++ b/components/exo/shell_surface.h
@@ -147,12 +147,15 @@ class ShellSurface : public SurfaceDelegate,
   // for the surface from the user's perspective.
   void SetGeometry(const gfx::Rect& geometry);
 
-  // Enable/disable rectangular shadow.
-  void SetRectangularShadow(bool enabled);
+  // [Deprecated] Set the content bounds for the shadow. Shell surface
+  // geometry will be used if bounds are empty. Setting empty bounds
+  // will disable the shadow.
+  void SetRectangularShadow_DEPRECATED(const gfx::Rect& content_bounds);

[reveman, 2017/02/03 17:47:01]

Remove _DEPRECATED here. See my comment in server.cc.

 
   // Set the content bounds for the shadow. Shell surface geometry will be
-  // used if bounds are empty.
-  void SetRectangularShadowContentBounds(const gfx::Rect& content_bounds);
+  // used if bounds are empty. Setting empty bounds will disable the shadow.
+  // Setting empty bounds will disable the shadow.
+  void SetRectangularSurfaceShadow(const gfx::Rect& content_bounds);
 
   // Set the pacity of the background for the window that has a shadow.
   void SetRectangularShadowBackgroundOpacity(float opacity);
@@ -241,6 +244,8 @@ class ShellSurface : public SurfaceDelegate,
   aura::Window* shadow_overlay() { return shadow_overlay_; }
   aura::Window* shadow_underlay() { return shadow_underlay_; }
 
+  void set_shadow_enabled(bool enabled) { shadow_enabled_ = enabled; }

[reveman, 2017/02/03 17:47:01]

Remove this. See my comment in server.cc.

+
  private:
   class ScopedConfigure;
   class ScopedAnimationsDisabled;
@@ -321,6 +326,8 @@ class ShellSurface : public SurfaceDelegate,
   std::unique_ptr<ScopedAnimationsDisabled> scoped_animations_disabled_;
   int top_inset_height_ = 0;
   int pending_top_inset_height_ = 0;
+  // TODO(oshima): Remove this once NYC migration is complete.

[reveman, 2017/02/03 17:47:01]

I think we still need this for non arc clients. Please move this to the
deprecated function in server.cc.

+  bool shadow_underlay_in_shell_surface_ = true;
 
   DISALLOW_COPY_AND_ASSIGN(ShellSurface);
 };