Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml

Issue 2664403004: Use pixel coordinates for shadow underlay bounds (Closed)
Patch Set: update Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
diff --git a/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml b/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
index 89d3e97c22acf152f712301aca8828cdea0429ef..b13428ba9bd10c4bb15a1a08927b42f16575dee6 100644
--- a/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
+++ b/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
@@ -38,7 +38,7 @@
reset.
</description>
- <interface name="zcr_remote_shell_v1" version="2">
+ <interface name="zcr_remote_shell_v1" version="3">
<description summary="remote_shell">
The global interface that allows clients to turn a wl_surface into a
"real window" which is remotely managed but can be stacked, activated
@@ -140,7 +140,7 @@
</event>
</interface>
- <interface name="zcr_remote_surface_v1" version="2">
+ <interface name="zcr_remote_surface_v1" version="3">
<description summary="A desktop window">
An interface that may be implemented by a wl_surface, for
implementations that provide a desktop-style user interface
@@ -207,7 +207,7 @@
<request name="set_rectangular_shadow">
<description summary="set a rectangular shadow">
- Request that surface needs a rectangular shadow.
+ [Deprecated] Request that surface needs a rectangular shadow.
This is only a request that the surface should have a rectangular
shadow. The compositor may choose to ignore this request.
@@ -398,6 +398,27 @@
of this request.
</description>
</request>
+
+ <!-- Version 3 additions -->
+ <request name="set_rectangular_surface_shadow" since="3">
+ <description summary="set a rectangular shadow">
+ Request that surface needs a rectangular shadow.
+
+ This is only a request that the surface should have a rectangular
+ shadow. The compositor may choose to ignore this request.
+
+ The arguments are given in the remote surface coordinate space and
+ specifies inner bounds of the shadow.
+
+ The arguments are given in the remote surface coordinate space.
reveman 2017/02/03 02:22:18 nit: you already mention this above
oshima 2017/02/03 17:33:16 Done.
+ Specifying zero width and height will disable the shadow.
+ </description>
+ <arg name="x" type="int"/>
+ <arg name="y" type="int"/>
+ <arg name="width" type="int"/>
+ <arg name="height" type="int"/>
+ </request>
+
</interface>
<interface name="zcr_notification_surface_v1" version="1">

Powered by Google App Engine
This is Rietveld 408576698