MD Settings: Internet: Convert 'Known Networks' page to dropdown menus

chrome/browser/resources/settings/internet_page/internet_known_networks_page.js

Index: chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
index bbd19d2da0cdbedcdee22f47568d16e2ef4ea2ce..0d7264573b6063a6bf29991bfaf632a29a0d5601 100644
--- a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
@@ -38,6 +38,12 @@ Polymer({
     },
   },
 
+  /** @private {string} */
+  selectedGuid_: '',
+
+  /** @private {boolean} */
+  selectedIsPreferred_: false,
+
   /**
    * Listener function for chrome.networkingPrivate.onNetworksChanged event.
    * @type {function(!Array<string>)}
@@ -130,20 +136,32 @@ Polymer({
   },
 
   /**
-   * @param {!{model: !{item: !CrOnc.NetworkStateProperties}}} e
+   * @param {!Event} event
    * @private
    */
-  onRemoveTap_: function(e) {
-    var state = e.model.item;
-    this.networkingPrivate.setProperties(state.GUID, {Priority: 0});
+  onMenuButtonTap_: function(event) {

[michaelpg, 2017/02/01 23:43:41]

opt nit: |e| for consistency

[stevenjb, 2017/02/02 01:54:44]

I remove the unused 'e' parameters below instead.

+    var button = /** @type {!HTMLElement} */ (event.target);
+    this.selectedGuid_ = button.getAttribute('guid');

[michaelpg, 2017/02/01 23:43:41]

actually, I'm already getting rusty, but IIRC |event| should have a |model| for
the item that created this dom-repeat entry.

something like "event.model.item" should be the actual network state object.

[michaelpg, 2017/02/01 23:43:41]

button.dataset['guid']

[stevenjb, 2017/02/02 01:54:44]

Oh, hey, yeah, you're right. Forgot about that, thanks.

+    this.selectedIsPreferred_ = button.id == 'preferredDots';
+    /** @type {!CrActionMenuElement} */ (this.$.dotsMenu).showAt(button);
+    event.stopPropagation();
   },
 
-  /**
-   * @param {!{model: !{item: !CrOnc.NetworkStateProperties}}} e
-   * @private
-   */
-  onAddTap_: function(e) {
-    var state = e.model.item;
-    this.networkingPrivate.setProperties(state.GUID, {Priority: 1});
+  /** @private */
+  onRemovePreferredTap_: function() {
+    this.networkingPrivate.setProperties(this.selectedGuid_, {Priority: 0});
+    /** @type {!CrActionMenuElement} */ (this.$.dotsMenu).close();
+  },
+
+  /** @private */
+  onAddPreferredTap_: function(e) {
+    this.networkingPrivate.setProperties(this.selectedGuid_, {Priority: 1});
+    /** @type {!CrActionMenuElement} */ (this.$.dotsMenu).close();
+  },
+
+  /** @private */
+  onForgetTap_: function(e) {
+    this.networkingPrivate.forgetNetwork(this.selectedGuid_);
+    /** @type {!CrActionMenuElement} */ (this.$.dotsMenu).close();
   },
 });