MD Settings: Internet: Convert 'Known Networks' page to dropdown menus

chrome/browser/resources/settings/internet_page/internet_known_networks_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-internet-known-networks' is the settings subpage listing the
  * known networks for a type (currently always WiFi).
  */
 Polymer({
@@ skipping 20 matching lines @@
      * @private {!Array<!CrOnc.NetworkStateProperties>}
      */
     networkStateList_: {
       type: Array,
       value: function() {
         return [];
       }
     },
   },
 
+  /** @private {string} */
+  selectedGuid_: '',
+
+  /** @private {boolean} */
+  selectedIsPreferred_: false,
+
   /**
    * Listener function for chrome.networkingPrivate.onNetworksChanged event.
    * @type {function(!Array<string>)}
    * @private
    */
   networksChangedListener_: function() {},
 
   /** @override */
   attached: function() {
     this.networksChangedListener_ = this.onNetworksChangedEvent_.bind(this);
@@ skipping 72 matching lines @@
    * @return {boolean}
    * @private
    */
   haveNotPreferred_: function() {
     return this.networkStateList_.find(function(state) {
       return this.networkIsNotPreferred_(state);
     }.bind(this)) !== undefined;
   },
 
   /**
-   * @param {!{model: !{item: !CrOnc.NetworkStateProperties}}} e
+   * @param {!Event} event
    * @private
    */
-  onRemoveTap_: function(e) {
-    var state = e.model.item;
-    this.networkingPrivate.setProperties(state.GUID, {Priority: 0});
+  onMenuButtonTap_: function(event) {

[michaelpg, 2017/02/01 23:43:41]

opt nit: |e| for consistency

[stevenjb, 2017/02/02 01:54:44]

I remove the unused 'e' parameters below instead.

+    var button = /** @type {!HTMLElement} */ (event.target);
+    this.selectedGuid_ = button.getAttribute('guid');

[michaelpg, 2017/02/01 23:43:41]

actually, I'm already getting rusty, but IIRC |event| should have a |model| for
the item that created this dom-repeat entry.

something like "event.model.item" should be the actual network state object.

[michaelpg, 2017/02/01 23:43:41]

button.dataset['guid']

[stevenjb, 2017/02/02 01:54:44]

Oh, hey, yeah, you're right. Forgot about that, thanks.

+    this.selectedIsPreferred_ = button.id == 'preferredDots';
+    /** @type {!CrActionMenuElement} */ (this.$.dotsMenu).showAt(button);
+    event.stopPropagation();
   },
 
-  /**
-   * @param {!{model: !{item: !CrOnc.NetworkStateProperties}}} e
-   * @private
-   */
-  onAddTap_: function(e) {
-    var state = e.model.item;
-    this.networkingPrivate.setProperties(state.GUID, {Priority: 1});
+  /** @private */
+  onRemovePreferredTap_: function() {
+    this.networkingPrivate.setProperties(this.selectedGuid_, {Priority: 0});
+    /** @type {!CrActionMenuElement} */ (this.$.dotsMenu).close();
+  },
+
+  /** @private */
+  onAddPreferredTap_: function(e) {
+    this.networkingPrivate.setProperties(this.selectedGuid_, {Priority: 1});
+    /** @type {!CrActionMenuElement} */ (this.$.dotsMenu).close();
+  },
+
+  /** @private */
+  onForgetTap_: function(e) {
+    this.networkingPrivate.forgetNetwork(this.selectedGuid_);
+    /** @type {!CrActionMenuElement} */ (this.$.dotsMenu).close();
   },
 });