device/fingerprint/public/interfaces/fingerprint.mojom - Issue 2664353002: Host fingerprint mojo service within the device service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/fingerprint/public/interfaces/fingerprint.mojom

Issue 2664353002: Host fingerprint mojo service within the device service. (Closed)

Patch Set: try to fix BUILD.gn Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module device.mojom;

	6

	7 interface BiodObserver{

	8 OnRestarted();

	9 OnScanned(uint32 scan_result, bool is_complete);
	Tom Sepez 2017/02/01 16:30:17 is scan_result really a uint32, or some sort of en is scan_result really a uint32, or some sort of enum? xiaoyinh(OOO Sep 11-29) 2017/02/02 23:25:59 Thanks for your comment. You're right, scan_resul Show quoted text On 2017/02/01 16:30:17, Tom Sepez wrote: > is scan_result really a uint32, or some sort of enum? Thanks for your comment. You're right, scan_result is a enum and it will be defined in third_party/cros_system_api/dbus/service_constants.h along with other fingerprint related constants. I can keep a copy of the enum here if that's desired.
	10 OnAttempt(uint32 scan_result, array<string> recognized_user_ids);

	11 OnFailure();

	12 };

	13

	14 interface Fingerprint {

	15 GetFingerprintsList() => (array<string> enrollments);
	Tom Sepez 2017/02/01 16:30:17 Is this a privileged interface? Which clients do Is this a privileged interface? Which clients do you expect to call this? Are the callers more trusted than the service itself? xiaoyinh(OOO Sep 11-29) 2017/02/02 23:25:59 I think right now only md-settings and lock screen Show quoted text On 2017/02/01 16:30:17, Tom Sepez wrote: > Is this a privileged interface? Which clients do you expect to call this? Are > the callers more trusted than the service itself? I think right now only md-settings and lock screen will call this. And they are inside the chrome process, so I assume they are more trusted than the service itself. Let me know if you think otherwise.
	16 StartEnroll(string user_id, string label);

	17 CancelCurrentEnroll();

	18 GetLabel(int32 index) => (string label);

	19 SetLabel(string label, int32 index);

	20 RemoveEnrollment(int32 index);

	21 StartAuthentication();

	22 EndCurrentAuthentication();

	23 DestroyAllEnrollments();

	24 AddBiodObserver(BiodObserver observer);

	25 };

	26

OLD	NEW

« no previous file with comments | « device/fingerprint/public/interfaces/OWNERS ('k') | services/device/BUILD.gn » ('j') | no next file with comments »