services/device/fingerprint/fingerprint_impl.h - Issue 2664353002: Host fingerprint mojo service within the device service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/device/fingerprint/fingerprint_impl.h

Issue 2664353002: Host fingerprint mojo service within the device service. (Closed)

Patch Set: Modify BUILD.gn Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« services/device/fingerprint/BUILD.gn ('K') | « services/device/fingerprint/fingerprint_export.h ('k') | services/device/fingerprint/fingerprint_impl_chromeos.h » ('j') | services/device/fingerprint/fingerprint_impl_chromeos.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef SERVICES_DEVICE_FINGERPRINT_FINGERPRINT_IMPL_H_

	6 #define SERVICES_DEVICE_FINGERPRINT_FINGERPRINT_IMPL_H_

	7

	8 #include "services/device/fingerprint/fingerprint_export.h"

	9 #include "services/device/public/interfaces/fingerprint.mojom.h"

	10

	11 namespace device {

	12

	13 class FingerprintImpl {
	blundell 2017/02/06 14:52:43 nit: This class can be called Fingerprint (that's nit: This class can be called Fingerprint (that's one of the reasons the nested mojom namespace was introduced for generated code). xiaoyinh(OOO Sep 11-29) 2017/02/22 00:04:50 Done. Show quoted text On 2017/02/06 14:52:43, blundell wrote: > nit: This class can be called Fingerprint (that's one of the reasons the nested > mojom namespace was introduced for generated code). Done.
	14 public:

	15 SERVICES_DEVICE_FINGERPRINT_EXPORT static void Create(
	blundell 2017/02/06 14:52:43 nit: A comment would be useful here. ("Implemented nit: A comment would be useful here. ("Implemented in platform-specific subclasses"). xiaoyinh(OOO Sep 11-29) 2017/02/22 00:04:50 Done. Show quoted text On 2017/02/06 14:52:43, blundell wrote: > nit: A comment would be useful here. ("Implemented in platform-specific > subclasses"). Done.
	16 device::mojom::FingerprintRequest request);

	17 };

	18

	19 } // namespace device

	20

	21 #endif // SERVICES_DEVICE_FINGERPRINT_FINGERPRINT_IMPL_H_

OLD	NEW