Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 2664333003: Throw input error instead of parser error to avoid crashing. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Throw input error instead of parser error to avoid crashing. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/7be9cd0ded0ec5595ff77a135facd0ae8b1b7151

Patch Set 1 #

Patch Set 2 : Updated status files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -27 lines) Patch
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 3 chunks +13 lines, -12 lines 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 4 chunks +9 lines, -9 lines 0 comments Download
M pkg/front_end/test/fasta/outline.status View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 10 months ago (2017-02-01 17:20:34 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-01 17:28:52 UTC) #3
ahe
3 years, 10 months ago (2017-02-02 13:35:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7be9cd0ded0ec5595ff77a135facd0ae8b1b7151 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698