Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2664313002: Catch Uri.parse() FormatException and skip the URI. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Catch Uri.parse() FormatException and skip the URI. You saw it, and the stress test reproduced it too. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/17077ff2e0a20f54d901f276949ee9d338085552

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 1 chunk +6 lines, -1 line 1 comment Download
M pkg/analyzer/test/src/dart/analysis/file_state_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-01-31 21:48:27 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2664313002/diff/1/pkg/analyzer/lib/src/dart/analysis/file_state.dart File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right): https://codereview.chromium.org/2664313002/diff/1/pkg/analyzer/lib/src/dart/analysis/file_state.dart#newcode492 pkg/analyzer/lib/src/dart/analysis/file_state.dart:492: * Return the [FileState] for the given [relativeUri]. ...
3 years, 10 months ago (2017-01-31 21:51:23 UTC) #2
scheglov
3 years, 10 months ago (2017-01-31 21:55:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
17077ff2e0a20f54d901f276949ee9d338085552 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698