Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2664263002: Specify FutureOr. (Closed)

Created:
3 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 10 months ago
Reviewers:
floitsch, eernst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M docs/language/dartLangSpec.tex View 3 chunks +25 lines, -2 lines 3 comments Download

Messages

Total messages: 7 (2 generated)
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-01-31 18:38:03 UTC) #2
floitsch
LGTM!!
3 years, 10 months ago (2017-01-31 18:49:16 UTC) #3
eernst
LGTM, with just a small remark about the treatment of entities of kind `* -> ...
3 years, 10 months ago (2017-02-01 16:54:30 UTC) #4
Lasse Reichstein Nielsen
https://codereview.chromium.org/2664263002/diff/1/docs/language/dartLangSpec.tex File docs/language/dartLangSpec.tex (right): https://codereview.chromium.org/2664263002/diff/1/docs/language/dartLangSpec.tex#newcode7667 docs/language/dartLangSpec.tex:7667: The name \code{FutureOr} denotes the same \cd{Type} object as ...
3 years, 10 months ago (2017-02-02 06:45:47 UTC) #5
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-02-03 07:02:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c41ae1571338e331e04f652bab45cf66c58700db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698