Clears out external protocol data when cookies and site data is cleared.

chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc

Index: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
index 2e75283fc889e4db1a12f5d559f03a14ff754044..6c3b05167997aaaa51c83a0b68bebb22c0496c10 100644
--- a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
+++ b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
@@ -17,6 +17,7 @@
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/domain_reliability/service_factory.h"
 #include "chrome/browser/download/download_prefs.h"
+#include "chrome/browser/external_protocol/external_protocol_handler.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/history/web_history_service_factory.h"
 #include "chrome/browser/io_thread.h"
@@ -925,6 +926,11 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(
     webapp_registry_->UnregisterWebappsForUrls(filter);
 #endif
 
+  //////////////////////////////////////////////////////////////////////////////
+  // Remove external protocol data.
+  if (remove_mask & BrowsingDataRemover::REMOVE_COOKIES)

[dominickn, 2017/02/10 03:10:29]

REMOVE_SITE_DATA instead?

[msramek, 2017/02/10 17:20:12]

Note that REMOVE_SITE_DATA is a union of several types. This would work
correctly when used from the UI, but would otherwise be quite non-intuitive.
Please add a new datatype to the mask and then also add it as a disjunct of
REMOVE_SITE_DATA.

Please also add a testcase to chrome_browsing_data_remover_delegate_unittest.cc.

[ramyasharma, 2017/02/15 05:03:36]

Acknowledged.

[ramyasharma, 2017/02/15 05:03:36]

Thanks msramek, done.

+    ExternalProtocolHandler::ClearData(profile_);
+
   synchronous_clear_operations_.GetCompletionCallback().Run();
 }