Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 266423003: Produce cached data only for scripts which compile without errors. (Closed)

Created:
6 years, 7 months ago by marja
Modified:
6 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Produce cached data only for scripts which compile without errors. ScriptCompiler::CompileUnbound handles cached data only when there was no compilation error, so, if we produce the data for erroneous scripts, the ScriptData object is leaked. In addition, producing cached data for erroneous scripts makes little sense. R=ulan@chromium.org BUG=370327 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/parser.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
ulan, ptal
6 years, 7 months ago (2014-05-06 08:30:25 UTC) #1
ulan
lgtm
6 years, 7 months ago (2014-05-06 08:31:08 UTC) #2
marja
6 years, 7 months ago (2014-05-06 11:23:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21164 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698