Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2664213003: Add the generator and the generated files (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add missed files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24241 lines, -0 lines) Patch
A pkg/analyzer_plugin/doc/api.html View 1 chunk +2475 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/protocol/generated_protocol.dart View 1 chunk +10576 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/protocol/protocol.dart View 1 chunk +583 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/protocol/protocol_constants.dart View 1 chunk +87 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart View 1 chunk +514 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart View 1 1 chunk +731 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/integration/support/integration_tests.dart View 1 1 chunk +950 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/integration/support/protocol_matchers.dart View 1 1 chunk +1558 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/tool/spec/api.dart View 1 chunk +514 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/tool/spec/check_all_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/tool/spec/codegen_dart.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/tool/spec/codegen_dart_protocol.dart View 1 chunk +1276 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/tool/spec/codegen_inttest_methods.dart View 1 chunk +260 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/tool/spec/codegen_matchers.dart View 1 chunk +187 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/tool/spec/codegen_protocol_constants.dart View 1 chunk +161 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/tool/spec/from_html.dart View 1 chunk +553 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/tool/spec/generate_all.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/tool/spec/generate_files View 1 chunk +68 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/tool/spec/implied_types.dart View 1 chunk +89 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/tool/spec/plugin_spec.html View 1 chunk +2780 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/tool/spec/to_html.dart View 1 chunk +773 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
The generator code was copied from analysis_server, but has been modified in some places. If ...
3 years, 10 months ago (2017-01-31 18:44:36 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-01-31 18:50:51 UTC) #3
Brian Wilkerson
I missed three files, PTAL.
3 years, 10 months ago (2017-01-31 20:09:42 UTC) #4
scheglov
LGTM I didn't actually looked on these generated files.
3 years, 10 months ago (2017-01-31 20:10:56 UTC) #5
Brian Wilkerson
3 years, 10 months ago (2017-01-31 20:36:23 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
95c777fe7e1f581348b89db6e69e3ee38ddf8b8b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698